]> dgit.raspbian.org Git - gnome-shell.git/commit
workspaceAnimation: Assign movingWindow before creating window actors
authorSebastian Keller <skeller@gnome.org>
Fri, 27 Feb 2026 12:22:37 +0000 (13:22 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Sat, 14 Mar 2026 17:39:25 +0000 (18:39 +0100)
commitad701b958fef1b1513a23ebffdd783ebda75123e
treeb5fb575b4099be789e2dd931cfeb87704fed4e3f
parent20bf8f053f3174210ae40112d5808fe67e270d5e
workspaceAnimation: Assign movingWindow before creating window actors

The BaseWorkspaceGroup constructor calls _createWindows(), which uses
_shouldShowWindow() to determine which actors to create for the
animation.

In WorkspaceGroup _shouldShowWindow() this depends on a comparison with
this._movingWindow, which however only gets set after the
BaseWorkspaceGroup constructor has been called.

This was causing the moving window to no longer stick to the screen
when moved between workspaces.

Fixes: 96be47933 ("workspaceAnimation: Split out BaseWorkspaceGroup")
Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/8992
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4092>
(cherry picked from commit 45fb9698a5a99ef9af7dc2155d6b6766818d5197)
js/ui/workspaceAnimation.js